Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mrg] signup page checks and more #208

Merged
merged 2 commits into from
Aug 20, 2020
Merged

[mrg] signup page checks and more #208

merged 2 commits into from
Aug 20, 2020

Conversation

lucaslcode
Copy link
Member

move to markdown-it #196
signup page checks #206
forum link new tab #207
add hosting status to signup page

@lucaslcode
signup page checks and also:
02fd966 
move to markdown-it #196
signup page checks #206
forum link new tab #207
add hosting status to signup page
kalvdans
kalvdans requested changes Aug 19, 2020
View reviewed changes
Copy link
Member

@kalvdans kalvdans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change this line in model.py

hosting_status = Column(Enum(HostingStatus), nullable=True)

to

hosting_status = Column(Enum(HostingStatus), nullable=False)

and remove HOSTING_STATUS_UNKNOWN from api.proto as well.

app/backend/src/couchers/servicers/auth.py Outdated Show resolved Hide resolved
@lucaslcode
Copy link
Member Author

@kalvdans I didn't want to change the backend yet until db migrations are done, because it would break production right?

@kalvdans
Copy link
Member

sure, let's do db changes properly as part of #190 instead :)

@aapeliv aapeliv merged commit be2cd41 into develop Aug 20, 2020
@aapeliv aapeliv deleted the bugfix-frontend-signup-and-more branch August 20, 2020 01:24
aapeliv pushed a commit that referenced this pull request Apr 20, 2024
@darrenvong
chore: i18n translation keys for the search feature (#208)
f3be4bb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalvdans kalvdans kalvdans requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lucaslcode @kalvdans @aapeliv